Nicolas Grekas comments

Results 824 comments of


                                            Nicolas Grekas

[DependencyInjection] Add better return type on ContainerInterface::get()

Maybe we could add the phpdoc to the self::getContainer method? Even if it's not 100% accurate, this is a nice place to compromise. WDYT?

[make:security:form-login] Tweak login forms to enable double-submit CSRF protection

Ready to merge

[make:security:form-login] Tweak login forms to enable double-submit CSRF protection

Can we get this merged please? Form logins are broken right now :pray:

Segmentation Error while using Elasticsearch php's library bulk method

Did you spot an infinite loop that ends up in a segfault? If not, then this should be reported to php-src as segfaults should never happen.

make method signature compatible with PHP 8.5

/cc @Girgias FYI (until the issue is open on php-src). Closing as we shouldn't do this change of course.

run tests using PHPUnit 11.5

We need a way to register DebugClassLoader, and maybe a few other things. Basically what we do in SymfonyTestsListenerTrait.

run tests using PHPUnit 11.5

Thank you @xabbuh.

[HttpClient] Helper to get a file from a HttpClient Response

I wouldn't: the filename you're reading from the response is user input. I'd never use it on my own storage. Then, adding a method, I wouldn't either: that'd break the...

[Lock] Add `$prefix` parameter to avoid collision with `FlockStore`

I would do it diffently: since by default we have a shared lock space, we should still do that, or we might break apps. Then, for apps that need split...

[ErrorHandler] Add support for `@return-type-will-change`

Sorry I still don't get it. From the linked issue: > having both #[ReturnTypeWillChange] and @return together: if I understand well it will be no good for Drupal's BC -...