Nicolas Grekas
Nicolas Grekas
I like it :) Let's see how DI can leverage that for Autowiring now.
(rebase unlocked)
I just squashed+rebased the PR to target 6.2, please fetch and `reset --hard` before working again on the PR if you're still up to it. Please always rebase (never merge)...
I tried this test on the code and tests still pass. Could this be a locale-sensitive behavior? Can you provide us with a reproducer? ```diff --- a/src/Symfony/Component/DomCrawler/Tests/AbstractCrawlerTest.php +++ b/src/Symfony/Component/DomCrawler/Tests/AbstractCrawlerTest.php @@...
What's your system locale? Eg what does `setlocale(LC_CTYPE, '0');` return for you?
> We can also use #[Autoconfigure(tags: [['security.voter' => ['priority' => 3000]]])] but what about adding a #[AsVoter(priority: 3000)] attribute to make it easier ? I like this proposal about `#[AsVoter]`...
Oh, reading the source, I figured out we already have an attribute for that: `#[AsTaggedItem(priority: 100)]` would work equally well. Can you update the PR and its test cases to...
Rebase needed, in case there is anything left after #46328
Friendly ping @jderusse /cc @HypeMC Is this PR still needed after https://github.com/symfony/symfony/pull/46328?
Would you be able to take over the PR @HypeMC? I feel like @jderusse would appreciate :)