Nicolas Grekas comments

Results 804 comments of


                                            Nicolas Grekas

[Console] Table counts wrong number of padding symbols in method renderCell(..) when cell contain unicode variant selector

That's a rendering issue in the browser. What matters is how terminals display this. On mine, things are aligned.

Whitespace control when using twig components?

Most of the time it doesn't matter, sometimes it does :) eg the `:empty` pseudo-CSS class requires no spaces. Maybe there is nothing to do and ppl should use either...

Whitespace control when using twig components?

`:trim` could be nice as a generic Twig feature on its own!

[Validator] Add `configClass` option check to Yaml constraint using `symfony/config`

Let me close as I share the skepticism. We already have `Yaml` and `Json` constraints. I'd rather add a schema option to them (we can make the actual schema validator...

[DependencyInjection] Add better return type on ContainerInterface::get()

I don't think your interpretation of the BC policy is the one we're really sticking to. At least I don't agree with this argument when considering the current proposal. To...

[DependencyInjection] Add better return type on ContainerInterface::get()

The BC policy is designed to allow people to upgrade seamlessly. Seamlessly "means without us breaking their app". Yes we consider types in phpdocs, as guides toward what should be...

[DependencyInjection] Add better return type on ContainerInterface::get()

The "allowing" part is not our business, same as one can wire a logger into a service argument that needs a serializer: "PHP" will throw, not "us". People are free...

[DependencyInjection] Add better return type on ContainerInterface::get()

We're not responsible for how people configure their containers, really.

[DependencyInjection] Add better return type on ContainerInterface::get()

Sure, but still: the decorator has to act like the real objects, so the API will still be the same. SA tools won't be able to notice anyway, too many...

[DependencyInjection] Add better return type on ContainerInterface::get()

I don't know about the extension, but is the extension able to cope with scoped containers? Because having the extension know about the main DI one doesn't really help DX,...