Nicolas Grekas

Results 382 comments of Nicolas Grekas

/cc @welcoMattic would you have some time to check this one please? Maybe it conflicts with your PR related to using an AST? Or maybe you're just the right person...

In addition so @stof's comment, this would need a test case. But can you please improve the description to actually describe why this would be useful for? By just reading...

Can you please give a more concrete use case? I don't understand the point for now. This would need test cases of course before being accepted.

Thanks for the PR, that's always the best way to start a conversation on this repo :) Now that I double checked xxh3, it's not cryptographically secure, isn't it? Since...

Hi, thanks for the proposal and for opening the discussion. > I believe that a batch must be acknowledged or rejected entirely at once. Because it's a batch. If someone...

I'm :-1: for the reasons given by @stof. Closing therefore, thanks for suggesting.

Rereading this again I'm :-1: here: exposing new APIs is increasing the maintenance cost, and here, ppl will jump into using the method and shooting themself in the foot (see...

> One downside to all this is that it will complicate any merge-ups from lower version fixes. True. I've procrastinated reviewing this PR because changing for the sake of it...

> Autowire does not work even if it's in the same file. I need to add _defaults: { autowire: true} in the when@dev section There is some rightfulness in the...