Nicolas Grekas comments

Results 779 comments of


                                            Nicolas Grekas

[FrameworkBundle] Make `ValidatorCacheWarmer` and `SerializeCacheWarmer` use `kernel.build_dir` instead of `kernel.cache_dir`

I'm having a hard time reasoning about the way things work during warmup... Right now, we made warmers be called with $buildDir set to null during post-compile warmups. Would it...

[FrameworkBundle] Make `ValidatorCacheWarmer` and `SerializeCacheWarmer` use `kernel.build_dir` instead of `kernel.cache_dir`

Can you please rebase on top of 7.2?

[Form] Add `separator_html` option to display the `separator` text as HTML

Thank you @mboultoureau.

[Serializer] Skip uninitialized properties with deep_object_to_populate

Thank you @mtarld.

[PropertyAccessor] Ignore non-collection interface generics

What about considering this as an improvement and merging into 6.4? Then we can do the BC break in 7.0. I'd be fine saying those annotations aren't supported in 5.4...

[ErrorHandler] Don't format binary strings

Thank you @aleho.

[Intl][Emoji] Move emoji data in a new component

My understanding of this topic: - the intl data is NOT in the base skeleton. It is in webapp-pack. - even if the data is not compressed in the source,...

[Intl][Emoji] Move emoji data in a new component

```sh symfony new test-webapp --webapp du -sh test-webapp #displays 154MB (uncompressed - 141MB just for vendor) rm test-webapp/vendor/symfony/intl/ -rf du -sh test-webapp #displays 109MB (still uncompressed - 96MB just for...

[Intl][Emoji] Move emoji data in a new component

Let's continue with this approach. 7% compressed diff also means less time to uncompress the app so that can lead to a slightly better DX. rebase needed though :)

[Intl][Emoji] Move emoji data in a new component

> I can reduce 25% of uncompressed data files... by removing all spaces (only 3/4% when compressed... as expected) not worth it to me > Do we need to php-cs-fix...