Nicolas Grekas

Results 831 comments of Nicolas Grekas

Please check #54455 for a possible solution to these ambiguities. Can you make your code behave more predictably with this PR @janklan?

I played with the reproducer and I confirm all cases are fixed by #54455, provided we set framework.controller_resolver.auto_mapping to false

> All my remaining concerns are related to the compilation process: discovering new service definitions in AutowirePass means we won't execute previously ran compiler passes on them. We could register...

About my remaining concerns (`ResolveNamedArgumentsPass`, `ResolveChildDefinitionPass` and other pass not running), I'm wondering if we shouldn't add a new `ResolveAutowireInlineAttributesPass` that would scan autowired services for this attribute and would...

This doesn't make sense to me. We exclude `\n` because it's here "twice": one explicit, two as a real new line. But I do want to be able to copy/paste...

Closing as explained, thanks for proposing.

Not a bug to me, that fits my comment above.

Hi, thanks for working on this topic. Would there be a way to put that concern in Doctrine itself, by decorating the Connection object? I'm concerned that the current approach...

> further improve it by ensuring that this check is only done if the request contains an SQL query This might complicate things a lot, isn't it? Personally, I'd be...