Nicolas Grekas

Results 382 comments of Nicolas Grekas

To my understanding of HTTP, 404 is the correct status code: an invalid value for the inside is an unmapped URL from the outside - aka a 404 not found....

PHP doesn't enforce the name on arguments on child implementations. This means they shouldn't be use when coding against interfaces.

Your fix is the right one: PSR-7 doesn't specify whether we should seek or not, so it's your job to ensure the offset.

As I put in #207, this is not explicitly allowed by PSR-7, so doing that would enable building on a non-specified behavior, enabling tight-coupling to one specific implementation. Instead, I'd...

Side note: if you call `detach()` on the body Stream object to clear the internal resource stream. This might be portable. See https://github.com/php-http/cache-plugin/pull/82 for how caching can leverage this at...

Closing as nobody else reported the issue and this stalled.

This is not something that we can fix at our level. This should be fixed by the PSR first.