Nicolas Grekas

Results 829 comments of Nicolas Grekas

In #49347, I manually added `@return void` to a few interfaces (DataCollectorInterface, LateDataCollectorInterface and ResetInterface). I think it would be great to have a PR dedicated to ensuring that all...

Note that `ResetInterface::reset()` is an interesting case because we cannot document its return type as `mixed|void`.

`*ExceptionInterface::getCode` are false positives, we don't need to document their return type. These also, because the interface has an `@template` annotation: ``` Symfony\Contracts\HttpClient\ResponseStreamInterface::next Symfony\Contracts\HttpClient\ResponseStreamInterface::valid Symfony\Contracts\HttpClient\ResponseStreamInterface::rewind ``` Might be the case...

To anyone willing to help on this issue: tests don't need to be updated, unless required by the changes on non-test files. We don't care about provider or methods having...

LGTM after a few changes I just pushed, but I agree with @stof it'd be great to get rid of this strange event-dispatcher + listener logic to start/stop sections. Doable...