Nicolas Grekas

icon company @SymfonyCorp icon location Paris, France icon location Submitting features and bug(fixes) @symfony, to make it always faster, easier to use and better designed, uncompromising. @ESPCI_Alumni engineer.

Results 788 comments of Nicolas Grekas

[DoctrineBridge][Validator] Allow validating every class against unique entity constraint

Can you please rebase (and squash while doing so)? We don't merge PRs with merge commits in them.

[DoctrineBridge][Validator] Allow validating every class against unique entity constraint

I guess the UI doesn't help, I never use it myself. Yes, please squash all commits into one.

[HttpKernel] Add support for custom HTTP status code for the MapQueryParameter attribute

Thank you @ovidiuenache.

[Messenger] schema assets filter causes TypeError

A regression maybe, a BC break nope ;)

fix: remove unwanted cast to int

Thank you @Ahummeling.

[Tests] Polyfills not loaded

That's how it's supposed to work to me: the internal function (the native one, non-polyfilled) is not found since you're on PHP 8.1 Try running this on PHP 8.3, it...

Inconsistent controller name validation in make:controller command

Would you be able to send a PR to have a look at the code and send a PR?

[Cache] Allow to use namespace delimiter in cache key

@vtsykun up to resume this PR?

[Cache] Allow to use namespace delimiter in cache key

@dorrogeray follow up PR welcome then!

[Validator] UlidValidator should accept RFC4122 formatted ULID

I think this ship has sailed. It would be unexpected to accept RFC-formatted ULIDs now. We could make it easier to accept ULIDs via the Uuid constraint instead. Up to...