Nicolas Grekas comments

Results 382 comments of


Nicolas Grekas

[Validator] UlidValidator should accept RFC4122 formatted ULID

Or add an option to the `Ulid` constraint actually!

[Notifier] Add `debugData` property to `SentMessage` class

Looking at the linked issue, this is not about debugging but rather about providing extra info. Maybe a generic `getInfo()` could work - and we'd ensure this contains the response...

[Notifier] Add `debugData` property to `SentMessage` class

> Having a free-form array where each transport can add anything looks like a bad idea. In HttpClient we documented the standard info keys, and decorators can add their own...

[Security] Add a normalization step for the user-identifier in firewalls

> When enable, please note that the user provider or the user repository should be adapt: do we have any advice on the topic? Or any things we can anticipate...

[Process] `ExecutableFinder::addSuffix()` has no effect

Can you please check if this bugfix shouldn't be applied to either 5.4 or 6.3 and rebase/retarget if yes?

[Process] `ExecutableFinder::addSuffix()` has no effect

@stof do you think we shouldn't merge this PR? To me it does no harm to have this capability so I'm fine merging it.

[Process] `ExecutableFinder::addSuffix()` has no effect

@TravisCarden can you please rebase for 7.1? I think it'd be safer and more consensual to consider this as an improvement.

[Translation] What about putting translations in a cache pool?

We could but I suppose this should be optional so that we keep stellar perf by default for "static" needs?

[Translation] What about putting translations in a cache pool?

Let's do a small bench to help decide :)

[Serializer] Add support for union collection value types in `ArrayDenormalizer`

Anyone with more background on Serializer would be willing to review this PR? (note that it should target 7.1 for now, maybe 7.2 if we can't make it since we're...