Nicolas Grekas comments

Results 738 comments of


                                            Nicolas Grekas

trafficstars

[DependencyInjection] Reset env vars when resetting the container

Yes!

Do not add a `ReflectionClassResource` to the container when class is annotated with `#[Excluded]`

The `#[Excluded]` attribute maps to the `container.excluded` tag, that's what we should rely on to build this rule. Also, we should have an attribute on the tag that should make...

Do not add a `ReflectionClassResource` to the container when class is annotated with `#[Excluded]`

I'd prefer a solution that relies only on the tag, not on the attribute directly.

[Validator] Add the `Charset` constraint

Just bikeshadding about the name: what about Charset?

[Validator] Add the `Charset` constraint

My thoughts: On all my apps, I'd want to reject any non-UTF-8 content. It might already be the case when the DB refuses to persist invalid UTF-8. So this contraints...

[Validator] Add the `Charset` constraint

Thank you @alexandre-daubois.

Public readonly properties

Can you provide a reproducing test case please?

This test case fails: ```php --TEST-- Verifies that public readonly properties can be used --FILE-- --EXPECTF-- cookies ``` The reason is that `PublicScopeSimulator` generates an accessor that returns by reference...

[HttpFoundation] Support for RFC9213 Targeted HTTP Cache Control

I don't think we should support `Surrogate-Control`. It didn't get traction and the RFC is better aligned to current practices. Could we have this with "just" an extra `$target` argument...

[HttpFoundation] Support for RFC9213 Targeted HTTP Cache Control

> It's supported by CloudFlare and Fastly now They also support the RFC so we don't need to support edge-arch. Another argument is that edge-arch and the RFC don't support...