Nicolas Grekas

Results 779 comments of Nicolas Grekas

Looking at your comments here, I wonder if we should keep #54668 or not? Maybe @yann-eugone can tell use how he wires the client so that we understant why adding...

I wonder if we need this PR at all: to me, the actual http client that does log should already have the logger wired. Did you check this aspect?

Please send a PR yes. Dunno why we have this cast to int honestly. Let's remove it.

I'd also like to be able to do this. In addition (or instead?) of configuring a service, this could support configuring the mapping directly: ```yaml doctrine: orm: typed_fields: App\My\CustomType: my_type...

`TypeFieldMapper` is in the `Orm` namespace, that's why it should be under `doctrine.orm`. It provides a mapping from the type on properties to the column type. That's in ORM because...

I wouldn't give up before trying. Would you like to give doctrine/dbal#4660 a try?

> Find a way to prevent people from using this type as an identifier This might be my preferred solution. Using U*IDs as primary keys is a bad practice anyway....

I just confirmed on a real app that this solves all ambiguities while providing nice DX.

> automapping logic is still being executed when explicitly disabled Actually it's not. There's a "disabled" option if you really want to disable any mapping.

PR rebased and ready to me. > There is no convenient way to disable that behaviour as of now There is to me: either provide an explicit mapping, or use...