Max Inden

Results 899 comments of Max Inden

Correct. We currently only run the _go-rust-interop-latest_ composition test instead of the _go-rust-interop_ composition test. https://github.com/libp2p/rust-libp2p/blob/b42f28630e2a7a04642c95aa8e7f4deea823f901/.github/workflows/interop-test.yml#L26-L32 https://github.com/libp2p/test-plans/blob/master/ping/_compositions/go-rust-interop.toml @laurentsenta do you know off the top of your head how much longer...

See https://github.com/libp2p/go-libp2p/pull/1762 for the corresponding change on go-libp2p.

I don't feel strongly about the name `client` in either, in case anyone wants to provide a patch.

Related to the change on `NetworkBehaviour`, I would like to to do the corresponding change to `ConnectionHandler` as well, namely to replace its `inject_*` methods with a single `on_event` method....

Cross-referencing implementation of this proposal https://github.com/libp2p/rust-libp2p/pull/2867.

> I think overriding `keep_alive` is orthogonal to the ping behaviour. Agreed. See https://github.com/libp2p/rust-libp2p/issues/2778.

> > > @mxinden @elenaf9 What do you think of adding `NotifyHandler::All`? > > > > > > I don't see a reason not to add it, and updating the...

@folex can you grant me permissions to merge `master` into your branch? I have a bunch of pull requests lined up, thus having me do it will safe a bit...

Substrate changing its ed25519 implementation does not require libp2p to change its implementation as well. The two projects can still be compatible. Do you know why they changed? Can you...

> How much do we care about that @mxinden? I don't have enough experience here. I would trust on your and @dignifiedquire expertise. > Could PL perhaps sponsor an audit?...