rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

swarm-derive: specify NetworkBehaviour by full path

Open folex opened this issue 3 years ago • 1 comments

Description

Specify NetworkBehaviour as ::libp2p::swarm::NetworkBehaviour in derive.

Links to any relevant issues

https://github.com/libp2p/rust-libp2p/issues/2921

Open Questions

Change checklist

  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] A changelog entry has been made in the appropriate crates

folex avatar Sep 22 '22 15:09 folex

@folex can you grant me permissions to merge master into your branch? I have a bunch of pull requests lined up, thus having me do it will safe a bit of time on both ends.

mxinden avatar Sep 22 '22 17:09 mxinden

@folex can you grant me permissions to merge master into your branch? I have a bunch of pull requests lined up, thus having me do it will safe a bit of time on both ends.

I don't see how to do that in GitHub without actually adding you to the fluencelabs org -_-

folex avatar Sep 26 '22 18:09 folex

@folex can you grant me permissions to merge master into your branch? I have a bunch of pull requests lined up, thus having me do it will safe a bit of time on both ends.

I don't see how to do that in GitHub without actually adding you to the fluencelabs org -_-

There is a checkbox next to the people that are subscribed to the PR that will allow us to push to this branch only.

thomaseizinger avatar Sep 27 '22 02:09 thomaseizinger

@folex can you grant me permissions to merge master into your branch? I have a bunch of pull requests lined up, thus having me do it will safe a bit of time on both ends.

I don't see how to do that in GitHub without actually adding you to the fluencelabs org -_-

There is a checkbox next to the people that are subscribed to the PR that will allow us to push to this branch only.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Seems like that doesn't work with organisations, only with personal forks. 🤔

folex avatar Sep 27 '22 08:09 folex