Max Inden comments

Results 899 comments of


                                            Max Inden

Simplify `ConnectionHandler` trait by removing as many associated types as possible

### Type Safety > Realistically, I think type-safety would not suffer much. I'd claim it is equally easy to mix up what to put in `InboundUpgrade` & `OutboundUpgrade` vs `inject_fully_negotiated_inbound`...

Simplify `ConnectionHandler` trait by removing as many associated types as possible

> > * For incoming substreams, we thus pass the actual substream all the way to the behaviour and end up polling the future there. > > As an aside,...

Simplify `ConnectionHandler` trait by removing as many associated types as possible

> * Wraps the future in a timeout > > * Never returns `None` (i.e. hides this in the type interface) If I may add a wish, first class bounding...

Add encode implementations for SocketAddr and IpAddr

Friendly ping @rnijveld.

Consider removing text::Encode in favour of serde::Serialize

I would be in favor of that. I should have thought of it before. @nox would you like to write a first proposal? Before you go all the way, I...

exporting metrics lists without registering them

If I understand you correctly https://github.com/prometheus/client_rust/pull/82 adds what you are looking for.

src/collector: Introduce Collector abstraction

Also //CC @sd2k

src/collector: Introduce Collector abstraction

And //CC @08d2

src/collector: Introduce Collector abstraction

> Am I understanding correctly that the user of the lib is expected to reimplement the `Collector` trait such that calling `collect()` will do whatever is necessary to produce the...

src/collector: Introduce Collector abstraction

Also note that the `encode` function takes an immutable reference to a `Registry`, thus two Prometheus servers (e.g. for fault tolerance) may scrape the same endpoint concurrently.