Max Inden

Thanks @thomaseizinger for the helpful review. Mind taking another look?

Once everyone is happy with the changes in `libp2p-swarm` I will start porting the many users of `libp2p-swarm` in `/protocols` to the new `NetworkBehaviour::on_event` methods. I plan to do so...

https://github.com/libp2p/rust-libp2p/pull/2867/commits/63b70fe60d723ce75510dc0cfea81302b92a7f58 provides default implementations for `NetworkBehaviour::on_swarm_event` and `NetworkBehaviour::on_connection_handler_event`, thus this patch set can be released as a non-breaking change. Once we remove the deprecated `NetworkBehaviour::inject_*` methods, I think we should...

Closing here in favor of https://github.com/libp2p/rust-libp2p/pull/3011.

Unfortunately there is no graceful shutdown for a libp2p node today. See https://github.com/libp2p/rust-libp2p/pull/1682 for a previous attempt. I don't think any of us are going to get to this any...

> Would you like it to be possible for the cache to be disabled? I would be in favor of it. Though more as an intuition and the expectation that...

> Implementations on `()` are not as easy to discover. I have to give this more thought. I agree that it makes it harder to discover. Also I don't find...

Can you update the pull request description?

> Should we strip the keep alive functionality from `libp2p-ping` as part of this PR or in a follow-up? Shall we follow the two step deprecation path as we did...

@thomaseizinger can you take a look at the clippy failure? ``` error: unused import: `NetworkBehaviour` Error: --> examples/ping.rs:44:21 | 44 | use libp2p::swarm::{NetworkBehaviour, Swarm, SwarmEvent}; | ^^^^^^^^^^^^^^^^ | = note:...