rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

transports/noise: Use proto2

Open mxinden opened this issue 2 years ago • 5 comments

Description

Update libp2p-noise to the latest specification change in https://github.com/libp2p/specs/pull/456.

See https://github.com/libp2p/specs/pull/456#pullrequestreview-1113439351 for a draft of a unit test to test compatibility. Might be helpful.

Motivation

See https://github.com/libp2p/specs/pull/456.

Are you planning to do it yourself in a pull request?

No

mxinden avatar Sep 21 '22 14:09 mxinden

See https://github.com/libp2p/go-libp2p/pull/1762 for the corresponding change on go-libp2p.

mxinden avatar Sep 21 '22 14:09 mxinden

Hi @mxinden I'm a Python dev who is looking at learning Rust. This is my first time really messing with a Rust project, so early apologies if I miss anything "obvious". :smile:

Also, I am new to libp2p (very interested in it, and trying to learn more about it). Any advice/feedback is welcomed. Thank you!

nloadholtes avatar Oct 10 '22 20:10 nloadholtes

Should we close this issue because we are moving towards proto3? @thomaseizinger

drHuangMHT avatar Mar 13 '24 02:03 drHuangMHT

I'll leave that for future maintainers to decide.

thomaseizinger avatar Mar 13 '24 03:03 thomaseizinger

Since https://github.com/libp2p/specs/issues/465 was accepted and https://github.com/libp2p/rust-libp2p/pull/3007 was closed, I'd say it makes sense to also close this one right?

jxs avatar Mar 13 '24 15:03 jxs