Max Inden

Results 899 comments of Max Inden

:wave: `libp2p` and `prometheus-client` maintainer here. Another benefit would be dependency consolidation. `libp2p` uses `prometheus-client` and in turn the lighthouse [network stack uses `prometheus-client`](https://github.com/sigp/lighthouse/blob/c3a793fd73a3b11b130b82032904d39c952869e4/beacon_node/lighthouse_network/Cargo.toml#L41).

I find `HistogramTimer` a need feature of the `prometheus` crate. I think it is worth proposing it to the `prometheus-client` crate @ackintosh.

> 3\. OpenCensus vs. Prometheus: In the past, we've used both tools, very inconsistently. If I understand correctly, OpenCensus is essentially another abstraction layer between the tracer and Prometheus, and...

> Open question: Is there any way to find out Prometheus' scrape frequency, so we can adjust our collection interval? Not that I am aware of, other than guessing it...

:wave: libp2p steward, rust-libp2p maintainer here. I was involved in the final steps of the protocol design and implemented Circuit Relay v2 on the Rust side recently. Happy to help...

> Do you have some interop setup in you use? Unfortunately not. We are working on interop tests via https://github.com/testground/testground though that is still far from complete. For now I...

> the best way to do periodic refreshing of reservations? Not sure whether this is a js-libp2p specific question, or a general question. In case it is of some help,...

Thanks for the ping @vmx. I am not quite sure I understand the consequences of this change for rust-libp2p. Do I understand correctly that we would need to special-case the...

Thanks for the ping @vmx! As far as I can tell our only usage of `Code::Identity` is in rust-libp2p's peer id handling: https://github.com/libp2p/rust-libp2p/blob/6cc3b4ec52c922bfcf562a29b5805c3150e37c75/core/src/peer_id.rs#L55-L112 Do I understand correctly that we would...