Max Inden
Max Inden
I am in favor of the proposals in this issue.
Good point @jxs. Doing the rename with the _hard deprecation_ (i.e. removal) of the `inject_` methods sounds good to me.
Not sure why the interoperability tests are failing. I assume due to: ``` Sep 28 11:02:14.311833 INFO 1.1452s FAIL > failed to dial 12D3KooWBK4ZGwm1kKpPucpiD57hGjvzuDvU4D6eyoLj5EQnNdcm: * [/ip4/16.0.0.4/tcp/1234] failed to negotiate security...
Very happy to see this happening! Thanks @umgefahren for the work and thanks @thomaseizinger for the reviews. Please ping me in case you need my input anywhere.
Cross-referencing related effort on the nim-libp2p side: https://github.com/status-im/nim-libp2p/pull/765 //CC @Menduist and @diegomrsantos
> I could file an issue with Arti describing the issues... although this would probably require writing an alternative. > In both cases, it may be worth reaching out to...
:wave: @nmathewson and ijackson, I hope you don't mind me pinging you here. First off, thank you for your work on https://gitlab.torproject.org/tpo/core/arti. You might remember a past call with me...
I did not forget about this. I am sorry for the delay.
> I will reach out to our legal team as well, just in case. I don't think we need to block on this. No objections from our legal team.
> Is it ok that the interoperability check always fails? And since the semver-checks were introduced in #2635 the CI doesn't get green anymore sadly. Interoperability tests are back to...