Max Inden

Results 899 comments of Max Inden

@thomaseizinger would you mind resolving the merge conflicts here? No rush, just a ping.

Closing here. @MerryPoppins92 please comment in case you need more help.

For the sake of type safety, what do you think of a _new type_ wrapping a `String` or `&str`?

> In order to not have to decide between the two, we can have `Cow`. Not sure what is better for us or whether there is even a difference. >...

To be honest I haven't been aware of `DummyBehaviour::with_keep_alive`. Thanks @k0ur0x. I am closing here for now. I would still consider a pure `KeepAlive` `NetworkBehaviour` useful. That said, I doubt...

Thanks for creating this @elenaf9! Whenever you make a significant change to the original issue description, would you mind posting a comment like https://github.com/libp2p/rust-libp2p/issues/2052#issuecomment-827509552? That way, everyone subscribed to this...

Thanks for opening this up @DieracDelta! > As for an initial implementation, yesterday (if I understood correctly) @mxinden suggested augmenting the `poll` generated by deriving the `NetworkBehaviour` with `info` level...

I took a look at [cargo-release](https://github.com/crate-ci/cargo-release/). As far as I can tell from a small dry-run cargo-release could simplify the last step of a release, namely the publishing of the...

For the record, I did the `v0.49.0` release with `cargo release`. https://github.com/libp2p/rust-libp2p/pull/3028 updates our release documentation accordingly. This tool makes my life A LOT easier. Wonderful.

I am in favor of fully automating this. Do we know of any projects that do this today? (I am asking as I don't want rust-libp2p to be special here.)...