Niklas Mischkulnig

Results 290 comments of Niklas Mischkulnig

Indeed, but strangely enough that test passes for me locally on macOS 12.2.1 ...

Apparently, `copyfile` truncates the file on macOS 10.15 if source = destination, but not on macOS 12. I guess I'll have to add a check just like the one in...

> If not, maybe someone else wants to step up and get this over the finish line? I've tried to incorporate your feedback: https://github.com/libuv/libuv/pull/3654

There is some logic behind this: ```js // causes binding.constant to be false, is a constantViolation, not a referencePath x = 2; // causes binding.constant to be false, is a...

isReferenced seems to work as expected? https://astexplorer.net/#/gist/ad80f703aeeb6000eae28cf6bfcbe5a0/0e3b738842032410b7aa52c38da24c42faf0a731 (The Babel Slack might be the correct place for these questions)

that's per definition `false`: 🤷‍♂️ https://github.com/babel/babel/blob/36f9798f429d596c0f1efaf09570cd5396f37bd3/packages/babel-types/src/validators/isReferenced.js#L85-L88 ("referenced" might mean "reading access to a binding" instead of "refers of a variable" which is what you want)

So should Parcel be detecting the version of core-js that's installed, and then pass that version (e.g. "3.23.3") to swc as `preset_env_config.core_js`? (currently we use this preset env swc config:...

Sorry, my code sample didn't really represent my actual problem: the constructor parameters aren't compatible with napi values. So this doesn't compile ```rust #[napi(js_name = "Assets")] pub struct JsAssets {...