Michael Grunder

Results 185 comments of Michael Grunder

Hi @noxiouz sorry for the delay getting to this but I've been busy on another project. I'll try to get this tested/merged this weekend.

Closing in favor of rebased #1098

I'm going to merge this but first I need to make sure that the change to `dictGenHashFunction` doesn't somehow cause pain in upstream Redis. I think it's OK but we've...

I'm pretty unfamiliar with CMake but this does appear correct. I'll read up a bit on CMake's `find_package` and then get it merged.

So can this be closed then?

Merged, thanks! @chayim Thanks for the help!

Hi @bugwz, thanks for the PR. I was planning on landing [this branch](https://github.com/michael-grunder/hiredis/tree/reader-updates) soon which makes modifications to the same part of the code, in addition to making it faster....

Hi @bugwz I cherry-picked your test and it passes. I had to do some git shenanigans as this required `cherry-pick -n` and setting you as the author in the ultimate...

I can confirm this. What's happening is that we're not connected yet so [we attach the connect timeout](https://github.com/redis/hiredis/blob/be32bcdc8e84ae7dc091ceeffca2c5d4126f415c/async_private.h#L65) but since there is only one "timeout" struct in async it then...