Michael Grunder

Results 200 comments of Michael Grunder

> but sometimes the connection is ok, so, could you let it called by the caller? Presently we simply disconnect from the server when encountering a timeout, but the comment...

I used `getaddrinfo_a` for another project recently, so I think it is worth looking into. That said, IMHO the interface isn't great. The way it works is by spawning a...

Thanks for the PR, the updated CMakeLists.txt is much cleaner. I'm not very familiar with CMake, but is this change likely to cause pain for anyone if we were to...

> Since commits in #851 don't land in any release for the moment For some reason, I thought #851 was in v1.0.0. I'll give it a quick test and then...

The [onConnect](https://github.com/redis/hiredis/blob/8e0264cfd6889b73c241b60736fe96ba1322ee6e/async.h#L59) callback gives you a `const redisAsyncContext *ac` so you really shouldn't be mutating it there. What's the use case for this?

Closing as this is now possible as #931 was merged and then modified slightly in #1087

You are able to directly configure any ciphers or other TLS options by directly creating the `SSL` and `SSL_CTX` yourself and then calling [redisInitializeSSL](https://github.com/redis/hiredis#hiredis-openssl-wrappers). It's more work but lets you...

@lisay-yan does this answer make sense?

Hi, @ayeganov would you mind reworking the PR to match Hiredis' code style? I'd be happy to do it but it would add whitespace-only changes to the commit log. @yossigo...

I'm going to close this PR because I think the way to handle this level of specific SSL configuration is to create your own `SSL_CTX` and secure the connection with...