Michael Grunder
Michael Grunder
By vendoring hiredis it's possible to work against a specific version, right down to a single commit. I don't know if there are other reasons hiredis is vendored, specific to...
Hi, @casperisfine thanks for the report. Your fix looks good, but I'm wondering if there is a way to provide this without exposing the SSL context, as it would put...
Sorry about the delay, I'm going through old issues. It's certainly possible to add another flag. I suppose in this case it would have to be a flag accompanied with...
I've been going through all our old issues in preparation for the upcoming release and had time to look at this. Since we define `_XOPEN_SOURCE` the only feasible way to...
We do this in other parts of hiredis so it may be a reasonable change. I'll take a look at it.
Hi everyone, I don't think hiredis-node (or hiredis for that matter) presently have any active maintainers, but I created the [napi](https://github.com/redis/hiredis-node/tree/napi) branch as requested. I'm not a java/node dev but...
I'm hesitant to merge changes to the `sds` library because this code is also in [Redis itself](https://github.com/redis/redis/blob/ff3a3577f29a07e965b3b38d07894410d28da499/src/sds.h#L88) so we try to minimise divergence. How are you invoking the tests? Treating...
> If I manage to get a PR through in Redis itself, will that eventually end up in hiredis Yes for sure > Great! Cheers! Oups, now the macOS test...
Hi @ayeganov, I didn't write the SSL layer but it does feel like a `Resource Temporarily Unavailable` error should be handled like `EAGAIN` for an async context. I'll dig into...
@ayeganov Are you still having problems with this?