hiredis icon indicating copy to clipboard operation
hiredis copied to clipboard

Fix cmake config path on Linux.

Open xkszltl opened this issue 2 years ago • 4 comments

CMake config files were installed to /usr/local/share/hiredis, which is not recognizable by find_package(). I'm not sure why it was set that way. Given the commit introducing it is for Windows, I keep that behavior consistent there, but fix the rest.

xkszltl avatar Oct 05 '21 17:10 xkszltl

I'm pretty unfamiliar with CMake but this does appear correct. I'll read up a bit on CMake's find_package and then get it merged.

michael-grunder avatar Oct 05 '21 23:10 michael-grunder

Emmm....Actually after double checking I might be wrong. /usr/local/share/hiredis could be supported as well. Originally I saw it after packaging into rpm and think that doesn't look right, probably because rarely anyone uses that.

image

xkszltl avatar Oct 06 '21 07:10 xkszltl

So can this be closed then?

michael-grunder avatar Dec 23 '21 00:12 michael-grunder

Up to you, but I would recommend to merge. This PR fixed a "package not found" issue, although I'm not sure about the root cause because either way should be OK based on the doc.

xkszltl avatar Dec 23 '21 00:12 xkszltl

Merged, thanks!

@chayim Thanks for the help!

michael-grunder avatar Sep 01 '22 17:09 michael-grunder