Michael Grunder

Results 200 comments of Michael Grunder

> For the workaround, I just comment the code about options.connect_timeout and it work for me. That works too. My hack would allow you to still specify a connect timeout....

Thanks for the PR. I'm in favor of merging this, but I'm wondering whether this is _technically_ a breaking change? [Relevant XKCD](https://imgs.xkcd.com/comics/workflow.png)

Closing in favor of #1093 (which is just this PR rebased against master).

I'm seeing lots of build failures on Windows (but some successes). Is the plan to work through those or are they expected for the N-API implementation? Happy to merge into...

OK sounds great. I'll keep an eye on the PR.

Hi, thanks for the PR! The code looks fine to me. The only question I have is whether users are going to want to make the check optional (as opposed...

I've not heard of this before, but it looks interesting. * [Reference to the RFC](https://tools.ietf.org/html/rfc6555) * [An implementation in C](https://github.com/shtrom/happy-eyeballs-c) It seems reasonable to add this logic as long as...

Going to close this old issue, but feel free to reopen if you can provide an example program that demonstrates the problem.

Hi everyone, I'm not sure if there are any plans to add SSL support, but I think the current maintainers of hiredis-rb are @byroot and @fw42.

Hi all, I took a crack at adding this over in my fork, and it appears to work: https://github.com/michael-grunder/hiredis-rb/commits/ssl-support Disclaimer: I've never used Ruby or the Ruby extension API, so...