Michael Grunder

Thanks for the PR. This does improve things in terms of CMake. The only issue I see is that the change removes any distinction between v1.2.0 proper and the prerelease...

Appologies if I wasn't clear, but I will try to get this merged :smile: I just need to make sure we don't break existing code is all. The hiredis SONAME...

> Should we be creating wrappers and have checks with is_numeric and disabling the compression/serialization?** You could do that or use a distinct object for serverside operations like INCR. The...

Yes, I will take a look this weekend.

Yep, I'll get it merged this week.

We've seen no complaints with RC1 so I figure I'll release v1.1.0 this weekend.

Same thing happening in hiredis: https://github.com/redis/hiredis/actions/runs/3380340217/jobs/5613014442

Could you provide more context? I don't have a Windows machine to test this on. We do test setting TCP_KEEPALIVE under Windows and the tests are passing.

This seems reasonable to me. I don't mind merges directly to master if it isn't changing any code.

The issue I see with removing `-std=c99` is that it will lower the quality of diagnostics we get when doing non-standard things. I think Redis is now targeting `-std=c11` so...