Milos Djermanovic

Results 645 comments of Milos Djermanovic

> 1. I think that `baseConfig` and `overrideConfig` should both be relative to the `basePath` in the config array. I think it would be too confusing to try to make...

> 2\. Given that, we would need to keep `ignorePatterns` as an option to `FlatESLint` so that `--ignore-pattern` can be added outside of `overrideConfig`. I do agree that `--ignore-pattern` would...

Hi @terrablue, thanks for the issue! This rule has an option [`detectObjects`](https://eslint.org/docs/latest/rules/no-magic-numbers#detectobjects): > A boolean to specify if we should detect numbers when setting object properties Default is `false`: ```js...

I'll champion this. I think the best solution is to add a new option: `ignoreClassFieldInitialValues` (default `false` to keep the current default behavior).

> It looks like the pattern is passed into `fs.statSync` so that the correct type of iteration over the pattern/path can be performed (`_iterateFilesWithDirectory`, `_iterateFilesWithFile`, `_iterateFilesWithGlob`). We had a case...

> In both cases, "skipping" over the file that would be too long (if it wasn't a glob pattern) seems fine since `eslint` can't process the file any further anyways....

We could catch `ENAMETOOLONG` and rethrow it later if the glob search finds nothing (including when the glob search was not performed because the pattern didn't satisfy [conditions](https://github.com/eslint/eslint/blob/f0bb6099668f54ae6f444126b90dbb1146248146/lib/cli-engine/file-enumerator.js#L349) to be...

Suppressing file system errors is always problematic as it could mask other problems. > I am using `eslint` on parts of my source tree such that I can parallelize linting...

> When using report-unused-disable-directives, it would be perfect if it would also report unnecessary eslint-enable. Makes sense to me :+1:

> I can think of the following cases when `eslint-enable` will be unused- > > 1. ESLint rules are re-enabled but those have not been disabled. (When a rule is...