Milos Djermanovic

Results 687 comments of Milos Djermanovic

I guess the issue is that babel doesn't transform lookbehind assertions (because it probably isn't possible to do that), but there is no warning about that. Maybe this rule could...

Yes, it looks like this would need two different enhancements: 1. Checking regex literals. The rule now checks only `RegExp(string)` and `new RegExp(string)`. 2. Using configured `ecmaVersion`. This is usually...

I agree that disallowing block-scoped function declarations looks like just a stylistic preference, and therefore it doesn't seem it should be in `eslint:recommended`. However, function declarations are guaranteed to be...

Per our [semver policies](https://github.com/eslint/eslint#semantic-versioning-policy), we can change the default behavior of a rule in a non-major release only if the change fixes a bug or adds support for a newly-added...

As far as I know, this is how specifications and browsers treat block-level function declarations: * ES3 (there's only non-strict mode) * Specification: doesn't specify behavior. * Browsers: allowed, but...

@ljharb does the new option intentionally apply to [BinaryExpression](https://github.com/estree/estree/blob/master/es5.md#binaryexpression) nodes (e.g., `a + b `, `a === b`, `a < b`, `a in b`)? I'm asking because the original issue...

> ah, does that mean I’d need to add two options, binary and logical? I think there should be only one option that applies equally to both BinaryExpression and LogicalExpression...

> It ensures the “desktop” media queries aren't triggered on a 1024p-wide viewport, which has typically been a tablet (such as iPad) size. I'm confused now. If we don't want...

We have a policy of not removing rules: https://eslint.org/docs/user-guide/rule-deprecation

I would be in favor of removing rules when the benefit is removing dependencies. Of these two rules, only `valid-jsdoc` requires `doctrine`, so maybe we could leave `require-jsdoc`?