Milos Djermanovic

Results 645 comments of Milos Djermanovic

@DMartens it seems that https://github.com/eslint/eslint/pull/16102#discussion_r917449876 hasn't been addressed. For example, the following `if` can be safely autofixed to `a.b &&= foo;` but the current version provides a suggestion. ```js /*...

> 1. In the proposal the [canBeFixed](https://github.com/eslint/eslint/blob/5891c7533f500110129fdea7b9b63c8a409da0bd/lib/rules/operator-assignment.js#L49=) is linked which also allows fixing for `a.b = a.b || c` but according to the proposal this should be a suggestion. This...

> This rule is a great addition, but it's a shame that it didn't end up being named `logical-operator-assignment` to align with [`operator-assignment`](https://eslint.org/docs/rules/operator-assignment), as suggested in [#13689 (comment)](https://github.com/eslint/eslint/issues/13689#issuecomment-1160328857). @amitbeck thanks...

I can reproduce this, but only if the path starts with `/` and it happens only after the second `/`. It seems to be a problem with `levn`: ```js const...

I'll mark this as 'blocked' for now. Not sure if there's anything we could do in ESLint aside from upgrading `optionator` to a new version once the problem gets fixed.

This is still blocked on optionator/levn.

This works as intended. The rule considers only cases that appear in consecutive lines as an intentional fallthrough. I don't think we should change the default behavior because we don't...

Hi @domenic, thanks for the issue! By test cases for this rule, this seems to be intended behavior: https://github.com/eslint/eslint/blob/47be8003d700bc0606495ae42610eaba94e639c5/tests/lib/rules/no-misleading-character-class.js#L97-L100 I couldn't find any discussions about this in the original issue...

> But `/^[\u2747\uFE0F]$/u` is, in my opinion, not misleading, because it's pretty clear that there are two possible code points, of which only one will be matched. (This is despite...

`no-invalid-regexp` uses [regexpp](https://github.com/eslint/eslint/blob/66442a9faf9872db4a40f56dde28c48f4d02fc7b/lib/rules/no-invalid-regexp.js#L11) parser, not the configured parser, so the parser from eslint config doesn't affect the behavior of this rule. As for the original https://github.com/babel/babel/issues/11915 issue: > ```js >...