Milos Djermanovic
Milos Djermanovic
> I’m not sure it’s valuable to start going down the path of creating a new rule for each function that looks like a constructor. I agree. If we want...
I wouldn't mind replacing (deprecating) `no-new-symbol` with a rule that would work the same, just checking a list of variable names - `["Symbol", "BigInt"]` at this point - instead of...
Maybe something like `no-new-function` or `no-new-nonconstructor`?
Only `test/integration/fixtures/vscode` cwd loads `test/integration/fixtures/vscode/.eslintignore`. That works as intended. However, the patterns in that file should not ignore the `src/bootstrap-amd.js` file, but they do. In particular, it's ignored by [`**/fixtures/**`](https://github.com/fisker/flat-eslint-cmd-bug-repo/blob/b5d83269d9e6afe90d28169e8f0ac9acf4caff09/test/integration/fixtures/vscode/.eslintignore#L17)...
> Since the globby version we are using is really old, not sure what causes that. (I'm a maintainer of `globby`) I'm getting the same behavior with the latest globby...
> > Is this the intended behavior? > > Are you running the script inside `globby-test-ignore` or outside? Inside, `cwd` ends with `/globby-test-ignore`. I would expect that `**/globby-test-ignore/**` ignores `/my/absolute/path/to/globby-test-ignore/**/globby-test-ignore/**`,...
I can reproduce this behavior with `ignores` in our [`eslint.config.js`](https://github.com/eslint/eslint/blob/main/eslint.config.js). ```diff - } + }, + { + ignores: ["**/eslint/**"] + } ``` (my local clone is in a directory...
Here's a simplified example: ``` foo/ └── eslint.config.js ``` ```js // eslint.config.js module.exports = [{ ignores: ["**/foo/**"] }]; ``` Running `eslint "*.js"` in the directory `foo`. This is project's root...
@zloirock thanks for the issue! I can reproduce a significant difference in performance on my computer. With [`.eslintrc.js`](https://github.com/zloirock/core-js/blob/master/.eslintrc.js) running eslint takes ~1.5 min, while with [`eslint.config.js`](https://github.com/zloirock/core-js/blob/eslint-flat/eslint.config.js) it takes ~5 min...
This takes more than 2 minutes when linting [`eslint-flat`](https://github.com/zloirock/core-js/tree/00e94360baa038c59da967d0ac4771b580fb5b98): https://github.com/eslint/eslint/blob/8cc0bbe440dc5e6af6ef02f00d0514a40ca07c24/lib/linter/linter.js#L1604-L1609 It's merging ~800 custom globals over ~70 builtin globals for each of ~7000 files. To double-check, I ran this and...