Milos Djermanovic

Results 694 comments of Milos Djermanovic

> > I think it isn't a bug but a limitation of this rule as it can't know whether the function instance is just immediately invoked and then discarded, or...

@JoshuaKGoldberg just a reminder there are a few comments to address.

> do we want the filename to `.eslint-suppressions.json` or `eslint-suppressions.json` (without the leading dot)? I have a slight preference for the latter as I think tools are mostly moving away...

@softius I think https://github.com/eslint/eslint/pull/19159#discussion_r1984663419 hasn't been addressed?

Looks like a bug to me, so marking as accepted. The problems seems to be that the rule checks global scope, while in this example the variable `that` is declared...

> Prerequisite: [feat: fix false positives and negatives for consecutive backslashes #490](https://github.com/eslint/markdown/pull/490) This has been merged now.

In [`MD051`](https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md051---link-fragments-should-be-valid), the default is also `false`. I guess the default should depend on whether or not the links are expected to work when the document is rendered.

Here's an example: https://github.com/mdjermanovic/test-steps-env/blob/main/test.md `#oPTioNS` works the same as `#options` (scrolls to the heading when clicked), so if the criteria is how the document works when rendered and accessed on...

We should also update this: https://github.com/eslint/eslint/blob/1613e2e586423ec7871617aec4dce5c433f0e9f0/lib/rules/utils/regular-expressions.js#L11

I think we can fix this in `eslint-scope` in a minor (or patch?) release. @nzakas what do you think? Per the documentation, `Definition#name` should always be the `Identifier` node: https://eslint.org/docs/latest/extend/scope-manager-interface#name-1