Milos Djermanovic

Results 645 comments of Milos Djermanovic

With the performance fixes, I'm getting 89 seconds with `eslint.config.js`, 90 seconds with `.eslintrc.js`.

Hi @flq! Thanks for the issue and sorry for the lack of response. > ``` > /Users/.../EmbedBuildingBlockComponent.tsx > 30:13 warning Using target="_blank" without rel="noreferrer" (which implies rel="noopener") is a security...

> So it could be that for whatever reason the linter only gets to see a "version" where all comments are stripped. It could be that the comments are stripped,...

Can you check if you are running ESLint with [`--no-inline-config`](https://eslint.org/docs/latest/user-guide/command-line-interface#--no-inline-config) flag? Or, in the case that your setup runs ESLint through [API](https://eslint.org/docs/latest/developer-guide/nodejs-api#-new-eslintoptions), check if you have `allowInlineConfig: false` somewhere in...

Hi @c-harding, thanks for the issue! This was discussed in [PR #14963](https://github.com/eslint/eslint/pull/14963) which introduced the [`ignoreOnInitialization`](https://eslint.org/docs/latest/rules/no-shadow#ignoreoninitialization) option. The logic for this option is based on the assumption that a callback...

> Because ignores in `eslint.config.js` work differently than in `.eslintignore` and yet are expected to work together I don't think it's viable for the two different styles to work together,...

The same applies to `--ignore-pattern` CLI option. Assuming that we want to keep this option, I think the patterns should have the same syntax and semantics as patterns in config...

@nzakas I could take this if you haven't already started working on it.

One question before removing `ignorePatterns` FlatESLint constructor option: was it maybe added to handle `--ignore-pattern` CLI option, as [this comment](https://github.com/eslint/eslint/blob/6ba269ed673f965d081287b769c12beeb5f98887/lib/eslint/flat-eslint.js#L384) implies? I believe that patterns coming from `--ignore-pattern` should be...

> There is a distinction here: `baseConfig` (the default ESLint config) contains only patterns that begin with `**`, so it doesn't matter if they are resolved relative to `cwd` or...