Milos Djermanovic
Milos Djermanovic
> In theory this should improve runtime performance, although running it with `npm run perf` didn't actually seem to improve the numbers, and in fact, may have made them worse....
> Please double-check that config-array changes to see if they are actually matching the eslintrc behavior LGTM! Some possible further improvements: * eslintrc uses `Minimatch` class and keeps its instances,...
> Because this example has a glob without quotes, that means the shell is expanding it and is therefore not including dot files. Oh, I was running this in a...
I prepared https://github.com/eslint/eslint/pull/16269 to include dotfiles in glob and directory searches (per the RFC), if we decide that should be the behavior.
By the current behavior, do you mean current FlatESLint behavior or current eslintrc behavior?
In both eslintrc and the current implementation of flat config, dotfiles are effectively ignored in most cases, but the logic is not the same and there are many differences regarding...
Some notable differences in use cases, as a consequence of the different logic: * CLI: with eslintrc, unignoring a dotfile in `.eslintignore`/`ignorePatterns` is the way to automatically include it in...
Our `test` script includes: https://github.com/eslint/eslint/blob/8cc0bbe440dc5e6af6ef02f00d0514a40ca07c24/Makefile.js#L631-L638 Per the new standard, it shouldn't include linting, and `checkRuleFiles` and `checkLicenses` don't qualify as "execute code"? > ### Test > > Scripts that execute...
Regarding the `test` script, I still think it's good that it runs all the checks, including linting, that need to pass before accepting changes or publishing a new release. It's...
> > Per the new standard, it shouldn't include linting > > The spec says "SHOULD NOT" rather than "MUST NOT" so I think it's okay. :) > > >...