Martin Meyerhoff

Results 94 comments of Martin Meyerhoff

These specs would pass if https://github.com/solidusio/solidus_support/pull/94 was in a released `solidus_support` version. This gems runs the specs in a new bundle environment in which I can't set the source for...

## 💚 All backports created successfully | Status | Branch | Result | |:------:|:------:|:------| |✅|8.0-stable|[](https://github.com/AlchemyCMS/alchemy_cms/pull/3409)| ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

Let's keep it open. I'm fixing the issues that led to reverting Flickwerk support in `solidus_support`, and I'll rebase it when that is released. https://github.com/friendlycart/flickwerk/pull/3

I don't actually remember why I put this up. Closing.

This has the work from https://github.com/solidusio/solidus_support/pull/94 and should pass once #120 is merged.

> I keep coming back and looking at this PR... and I'm still both excited and intimidated by it. Is there anything I can do to augment the excitement and...

@jarednorman What about we find a time and record it together? I have a hard time talking to the computer alone. :)

I've managed to clean up the git history. We've gotten rid of the merge commits from `solidus_friendly_promotions`, and all the commits along with their messages are still there. I think...

So I like to do things fully and not leave unfinished business behind, and the `eligible` column is - to me - unfinished business. I agree it looks like a...

Yes, because https://github.com/solidusio/solidus/pull/5813 was merged between the opening the PR and merging it. I'll go and fix the warnings.