Martin Meyerhoff

Maybe the whole thing belongs into the `variant_price_selector_class`.

Rebased again. I've also provided backports for 3.1 and 3.2. Regarding the discussion with @jarednorman I totally think we should move the `currently_valid_prices` and `default_price` methods to the `variant_price_selector_class`, but...

@kennyadsl I'll provide a separate PR for `master` and `v3.2` once this is merged, alright?

I don't understand the question. It's a performance regression. It depends on Solidus' core's set of values whether that's a bug. Moving the two methods into another class in order...

I paired with @tvdeyen on this again today, and we found that we could actually move a lot of the logic into the `Spree::Variant::PriceSelector`, keeping the changeset smaller. This also...

We've tested this approach in our app and ran into errors! Turns out we have a bunch of discarded variants with discarded prices (as Solidus' current behavior is to discard...

@kennyadsl It's a bug but not a regression, in that it has been a bug for a long time. It's covered in this spec: https://github.com/solidusio/solidus/pull/4639/files#diff-f02d323d23d4cc20f7d7985235fa4ca043c81357b78a0fae2e41fe3bb4289480R307-R312 The more I look into...

I can update them on Wednesday, if you want to Backport before that, go ahead! Thank you!

Go ahead!

We've come across this as well, but we have opted not to add more stuff to the order state machine (which IMO does way too many things already). What we...