Martin Meyerhoff

> Would you be open to drop the discard of order level adjustment for this refactoring? I would not like order level discounts to be a thing. Order level *adjustments*...

Thank you @stem and @loicginoux for the detailed response! This is great. Regarding fixed-amount whole-order discounts: @loicginoux The way the `DistributedAmountsHandler` distributes the discount over several line items is using...

If we do that, how do we deal with the two columns going out of sync? And how would things be different than now after the next major version? When...

I've reworked the PR to not rename the column, but to add an additional `available_until` column that is updated alongside the `discontinue_on` column. That way we can safely deprecate and...

I'm fine adding the attribute to the API, no problem. Regarding the deprecation strategy though: Do you have a suggested solution?

Should I revert to the previous version of this PR then for the major release? It is unfortunate that users won't be warned about the disappearance of the column, but...

Reverted. I've left the `alias_attribute` and deprecation warnings in, so at least in some circumstances people get deprecation warnings.

I've found a bug in the promotion system that makes line-item level rules do things we don't want them to do, so I'm marking this as draft until I've got...

Hm, this got a bit bigger, but I think I got to a good place with this. I'm not deprecating the old rules; instead I leave them to do what...

@jarednorman I've re-requested your review because this now contains a bunch more change than what you initially reviewed.