Martin Meyerhoff

Results 36 issues of Martin Meyerhoff

This refactors the ActiveRecordAdapter to use Arel/ActiveRecord to merge conditions. The advantage is that we can finally merge scopes from different abilities! This only works with Rails versions 5.2+, so...

new feature

Your NPM package contains your tests, which in turn contain some vendored dependencies. For using the package, the tests are not necessary. It would be very nice to not bundle...

## Summary While working on the promotion system, I realized that unit cancels use `Spree::Adjustment#recalculate`. This is unfortunate, as that method does not work well for the improved promotions system,...

## Summary This adds an extension point for a configurable promotion adjuster to the app configuration, and uses that extension point to point to a new `Spree::Promotion::LegacyAdjuster`. This LegacyAdjuster does...

The API of promotion rules is a bit strange: There's the `applicable` method, which looks like promotion rules could apply to line items as well as orders, and there's `actionable?`,...

Enhancement
Solidus Admin
Solidus Core

**Description** This flag is not very useful and gives rise to bugs. It is not very useful, as we only need it to "resurrect" addresses that the user inputs newly,...

type:enhancement
changelog:solidus_api
changelog:solidus_core
release:major

In our business, the semantics of availability and discontinuation are not aligned with Solidus' nomenclature: A product can both be available and discontinued (i.e. we still have stock of it,...

Enhancement
Solidus Admin
Solidus Core
Hold

The current promotion system has a lot of problems, the most notable one being performance - however, the performance issues are really a symptom of architectural issues. We do need...

Enhancement
Solidus Admin
Solidus Core

## Summary This PR fixes a performance regression originating from #4076 and #4073. These two PRs fixed some inconsistencies by converting `variant.default_price` and `variant.currently_valid_prices` from associations to methods. Unfortunately, they...

Solidus Admin
Solidus Core
Needs Backport

In order to satisfy jurisdictions where invoice numbers have to conform specific formal requirements (number of digits, prefix, whatever) you can now define a `Spree::PrintInvoice::NumberFormattter` class which initializes with a...