Martin Meyerhoff

https://github.com/spree-contrib/spree_print_invoice/pull/87 will allow you to create PDFs for arbitrary Spree Models, among them Shipments. Because yes, what you want makes complete sense: A packaging slip for a shipment.

Would Solidus 4 then have this version, or the previous iteration? Alberto Vena ***@***.***> schrieb am Fr., 6. Mai 2022, 12:02: > Hey @mamhoff , thanks again for this work...

> [](https://github.com/stas/jsonapi.rb/blob/master/spec/dummy.rb#L97) > > Have you considered doing the decoration before the array is passed to the method? Yes - the problem is that the decoration materializes the ActiveRecord scope...

Sure, we can work around this issue in our local project; I found the fix I'm proposing here more elegant than writing that wrapper. I was confused about why the...

> The proposed changes are removing fixes for known and performance issues, like unscoping an ActiveRecord collection. I've looked through the commit history to find those issues, but I couldn't...

Depends on #5635

I think this is not correct behavior. The idea is here is that line items that should not be promoted will never be promoted, not even through an order-level promotion....

Rebased fromn `master`, removed the changelog entries (as I assume they're added back in when y'all release).

Closing in favor of https://github.com/friendlycart/solidus_friendly_promotions/

This is not to hold this back: We associate the same option value with multiple variants. We have a third field, an integer, that differentiates the variants from one another....