solidus_dev_support icon indicating copy to clipboard operation
solidus_dev_support copied to clipboard

Add tailwindcss-rails as runtime dep for solidus_dev_support

Open mamhoff opened this issue 1 year ago • 1 comments

This way, all extensions will have tailwind as their dev dependency.

mamhoff avatar Jun 19 '24 15:06 mamhoff

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

mergify[bot] avatar Jun 19 '24 15:06 mergify[bot]

This way, all extensions will have tailwind as their dev dependency.

Of course they will have it, once we add it 😏. But the question is why do all extensions need tailwind?

tvdeyen avatar Feb 12 '25 23:02 tvdeyen

I don't actually remember why I put this up. Closing.

mamhoff avatar Feb 13 '25 08:02 mamhoff