alchemy_cms icon indicating copy to clipboard operation
alchemy_cms copied to clipboard

Add an abstract collection option to the configuration class

Open mamhoff opened this issue 1 year ago • 2 comments

What is this pull request for?

Some of the configurations left in lib/alchemy.rb are sets of Pathname, or even sets of Configuration. This replacement for the InterListOption and StringListOption can deal with any collection of any type.

Found the need for this while trying to move the importmap configuration to the new configuration object...

Screenshots

Remove if no visual changes have been made.

Checklist

  • [x] I have followed Pull Request guidelines
  • [x] I have added a detailed description into each commit message
  • [x] I have added tests to cover this change

mamhoff avatar Feb 11 '25 10:02 mamhoff

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 97.11%. Comparing base (0555768) to head (7cc59cd). :warning: Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3189      +/-   ##
==========================================
+ Coverage   97.08%   97.11%   +0.02%     
==========================================
  Files         279      277       -2     
  Lines        7302     7336      +34     
==========================================
+ Hits         7089     7124      +35     
+ Misses        213      212       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Feb 11 '25 10:02 codecov[bot]

This pull request has not seen any activiy in a long time. Probably because of missing tests or a necessary rebase. This PR will be closed in 7 days if no further activity happens.

github-actions[bot] avatar May 25 '25 00:05 github-actions[bot]

This pull request has not seen any activiy in a long time. Probably because of missing tests or a necessary rebase. This PR will be closed in 7 days if no further activity happens.

github-actions[bot] avatar Aug 17 '25 00:08 github-actions[bot]

@mamhoff rebased with latest main

tvdeyen avatar Sep 19 '25 15:09 tvdeyen

💚 All backports created successfully

Status Branch Result
8.0-stable

Questions ?

Please refer to the Backport tool documentation

mamhoff avatar Oct 09 '25 01:10 mamhoff