Martin Meyerhoff
Martin Meyerhoff
@kennyadsl would you mind having a look? Would this also be a change for 4.0?
@kennyadsl I don't think I can meaningfully split it into smaller pull requests. I'm depecrating an API here, and I'm providing a replacement. I'm also implementing this change across the...
I think I do need to add more stuff from #4296 to this PR. Notably this will introduce bugs when re-calculating adjustments.
Rebased this PR on the current `master` branch. I've also added deprecation warnings for the scopes `Spree::UserAddress.archived` and `Spree::UserAddress.all_historical`.
@kennyadsl I changed the wording of the commit message. I've also kept the scopes to return all records instead of their custom behavior. If stores make use of that `archived`...
From @kennyadsl : Check if default billing / default shipping addresses are preserved with this change
Yes, i think that is what happens :) I'll provide a separate PR
@kennyadsl Extracted the behavior change to #4332, care to re-review? :)
> I'm ok removing the feature entirely in a minor version. Just saying that maybe we can postpone the database column removal to the next major by just using `ignored_columns`...
Should I remove the deprecated scopes here entirely then, or deprecate for Solidus 5?