In MapSplitter, ignore key-value separator after first
It is one important issue need to be fixed to support most cases which values may contain the separator.
for one example: I can make sure my key can't contain separator. but I can't make sure my value can't contain separator due to the value is generated by third-part service or special codec which can get separator. So I think we should fix this issue. It is common issue for most of case, Throwing IAE isn't reasonable or easier to let's happen low rating bug.
Can someone help to take a look at this PR. Thanks.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
- If you signed the CLA as a corporation, please let us know the company's name.
I signed it!
CLAs look good, thanks!
anyone can take a look?
@jiafu1115 Should this regard different types of splitters? Or add some method like ignoreExtraSeparator()?
@liach no. only change the inner behavior for MapSplitter. This is the simplest way to meet requirement.WDYT?Thanks
There must be a reason why it throws an exception when detecting more than one separators. You should ping a project manager.
@liach I had pinged the issue creator @cgdecker who is also the member for guava but no feedback util now. So I does not know who I should ping. so just waiting now.
I think we need to ping the authors of Splitter. @lowasser
@liach Thanks for your reminder. We may need to wait and wait and wait......
@eamonnmcmanus Thanks for your change for title, it is more clear now.
@raghsriniv can you help to review it? thanks
ask review