guava icon indicating copy to clipboard operation
guava copied to clipboard

In MapSplitter, ignore key-value separator after first

Open jiafu1115 opened this issue 9 years ago • 13 comments

It is one important issue need to be fixed to support most cases which values may contain the separator.

for one example: I can make sure my key can't contain separator. but I can't make sure my value can't contain separator due to the value is generated by third-part service or special codec which can get separator. So I think we should fix this issue. It is common issue for most of case, Throwing IAE isn't reasonable or easier to let's happen low rating bug.

Can someone help to take a look at this PR. Thanks.

jiafu1115 avatar Nov 30 '16 02:11 jiafu1115

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Nov 30 '16 02:11 googlebot

I signed it!

jiafu1115 avatar Nov 30 '16 02:11 jiafu1115

CLAs look good, thanks!

googlebot avatar Nov 30 '16 02:11 googlebot

anyone can take a look?

jiafu1115 avatar Dec 06 '16 09:12 jiafu1115

@jiafu1115 Should this regard different types of splitters? Or add some method like ignoreExtraSeparator()?

liach avatar Dec 07 '16 23:12 liach

@liach no. only change the inner behavior for MapSplitter. This is the simplest way to meet requirement.WDYT?Thanks

jiafu1115 avatar Dec 08 '16 00:12 jiafu1115

There must be a reason why it throws an exception when detecting more than one separators. You should ping a project manager.

liach avatar Dec 08 '16 00:12 liach

@liach I had pinged the issue creator @cgdecker who is also the member for guava but no feedback util now. So I does not know who I should ping. so just waiting now.

jiafu1115 avatar Dec 08 '16 00:12 jiafu1115

I think we need to ping the authors of Splitter. @lowasser

liach avatar Dec 08 '16 04:12 liach

@liach Thanks for your reminder. We may need to wait and wait and wait......

jiafu1115 avatar Dec 08 '16 05:12 jiafu1115

@eamonnmcmanus Thanks for your change for title, it is more clear now.

jiafu1115 avatar Dec 13 '16 09:12 jiafu1115

@raghsriniv can you help to review it? thanks

jiafu1115 avatar Nov 15 '19 21:11 jiafu1115

ask review

jiafu1115 avatar Jul 24 '25 00:07 jiafu1115