jdk
jdk copied to clipboard
openjdk
8356548: Avoid using ASM to parse latest class files in tests
For early eval; test by changing the ClassReader max accepted version of test ASM to 24 instead of 25
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8356548: Avoid using ASM to parse latest class files in tests (Sub-task - P4)
Reviewers
- Coleen Phillimore (@coleenp - Reviewer) 🔄 Re-review required (review applies to 4fc1b513)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25124/head:pull/25124
$ git checkout pull/25124
Update a local copy of the PR:
$ git checkout pull/25124
$ git pull https://git.openjdk.org/jdk.git pull/25124/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25124
View PR using the GUI difftool:
$ git pr show -t 25124
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25124.diff
Using Webrev
:wave: Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@liach This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8356548: Use ClassFile API instead of ASM to transform classes in tests
Reviewed-by: sspitsyn, lmesnik, coleenp, iklam
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 42 new commits pushed to the master branch:
- d4472979c43d9825ed2d008dbaed26dbf6d36180: 8367709: GenShen: Dirty cards for objects that get promoted by safepoint that intervenes between allocation and stores
- 844118a9d854459778f88d299b148c2288131344: 8369146: java/awt/PrintJob/GetGraphicsTest.java: Parse Exception: Invalid or unrecognized bugid: 50510568367702
- d7b525ab9980743cf0cab3e3daaa4ccb725bfea8: 8364673: Remove duplicate font mapping for itcavantgarde in psfontj2d.properties
- ... and 39 more: https://git.openjdk.org/jdk/compare/95def24b025341b5a6b99abdd4d1f3d26a40431c...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@liach The following labels will be automatically applied to this pull request:
hotspotserviceability
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.
Webrevs
- 08: Full - Incremental (697b8555)
- 07: Full - Incremental (e31476b1)
- 06: Full - Incremental (25972f2d)
- 05: Full - Incremental (a659f538)
- 04: Full - Incremental (020659f3)
- 03: Full - Incremental (4fc1b513)
- 02: Full - Incremental (3114f523)
- 01: Full - Incremental (cb02b045)
- 00: Full (b8fa795e)
@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
⚠️ @liach This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).
@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Thanks for the reviews! This should remove the hassles associated with new javac class files from value objects in the future. Integrating.
/integrate
Going to push as commit 3248aaf3c4f6784d5176e2a2c5bac0fbda47ee6b.
Since your change was applied there have been 43 commits pushed to the master branch:
- 9589a29d2515888b437d382204df22d01d4266ff: 8355752: Bump minimum boot jdk to JDK 25
- d4472979c43d9825ed2d008dbaed26dbf6d36180: 8367709: GenShen: Dirty cards for objects that get promoted by safepoint that intervenes between allocation and stores
- 844118a9d854459778f88d299b148c2288131344: 8369146: java/awt/PrintJob/GetGraphicsTest.java: Parse Exception: Invalid or unrecognized bugid: 50510568367702
- ... and 40 more: https://git.openjdk.org/jdk/compare/95def24b025341b5a6b99abdd4d1f3d26a40431c...master
Your commit was automatically rebased without conflicts.
@liach Pushed as commit 3248aaf3c4f6784d5176e2a2c5bac0fbda47ee6b.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.