Josh Rabinowitz

Results 131 comments of Josh Rabinowitz

@sobolevn it is still an issue. I see these issues so far: * when we use gawk, spaces in the full path are confusing the shell, for example here: https://github.com/sobolevn/git-secret/blob/master/src/commands/git_secret_init.sh#L39...

And here's the first error you'll encounter if you try to create a git-secret repo using a directory with spaces ```` % git clone [email protected]:repo.git 'checkout repo' % cd 'checkout...

Can anyone provide tips fixing these issues? Not a bash master here (yet)

Yeah, I've tried all sorts of quoting changes so far, I could use some specific guidance

https://gist.github.com/joshrabinowitz/df397ef108c3b16bd2ba331fea78e54a

Relevant: http://mywiki.wooledge.org/Quotes - "You can use the ${var:+..} parameter expansion" (to build options at runtime) I'm pretty sure this is extra important: ```` "rewrite the _get_gpg_local function to put those...

I think we should release 0.2.4 without this fix (since we don't have the fix yet).

This is fixed by PR #224, which should be in the next release

@sobolevn you're quite welcome! Thanks for all your time and work writing and supporting git-secret.

confirmed regression on current `master` branch. current automated testing asserts that using spaces with files works, but we don't test the case when a parent directory contains spaces.