Jon Atack

Results 159 comments of Jon Atack

Closing as this has been obsoleted by the merge of https://github.com/bitcoin/bips/pull/1576.

Agree, closing. As the author was last active six years ago, I'll open separate BIP-specific pulls with a cherry-picked commit by the original author.

Superseded by https://github.com/bitcoin/bips/pull/1584 that cherry-picks 81644ddfa131bb0e387ead2cc309ca18e57542b1.

Please keep comments focused on technical review of the proposal -- thanks.

Concept ACK, will have a look at this (and merged https://github.com/bitcoin/bitcoin/pull/27577 soon).

ACK e7158613dcafd0065a94b03c8013ee4ced8ec3e3 per `git range-diff 4b51290 80722d8 e715861`

re-ACK f58a5eee6ff69582d6e46e93dd52e07202d257a8 The unit test CI failures look unrelated -- I didn't reproduce them running `make check` locally (Clang 15 on ARM64). Edit: there are now more of the failures...

Fixup LGTM modulo squashing. The remaining CI failures are due to https://cirrus-ci.com/task/5963593934438400 (that seems unrelated?) and to https://github.com/bitcoin/bitcoin/issues/27001 that should be fixed in https://github.com/bitcoin/bitcoin/pull/26998.

re-ACK 0007d69f249068a14b9b5a97d46ace9dabdc2c8b