John Stilley

Results 306 comments of John Stilley

> Is this a good first issue for someone without access to the GUI? Yup! It looks to me like it is a bug in the code that reads blueprint...

PR is up: https://github.com/terrapower/armi/pull/458

@jakehader I know I turned on some YAML validation in this PR: https://github.com/terrapower/armi/pull/495 But @keckler , did that solve the problem in this issue? I suppose I never checked back...

@keckler Yeah, it stands to reason a similar thing would be happening everywhere we are using this YAML library. While I can't find any examples of this hurting people, it...

@onufer ~~This PR is just "Draft" right now, because I want to build an example (maybe for the docs?) and a unit test (which will be easy).~~ ~~But I wanted...

What about this Database method: https://github.com/terrapower/armi/blob/190c0caccfd36a0442118a1ae666c2a20c52a4d1/armi/bookkeeping/db/database.py#L78 and https://github.com/terrapower/armi/blob/190c0caccfd36a0442118a1ae666c2a20c52a4d1/armi/bookkeeping/db/database3.py#L790 Are those `geomString` arguments still necessary?

@drewejohnson @keckler @jakehader Would any of you notice or care if ARMI finally dropped all support for the old Geometry XML files? First off, I'm not sure we have full,...

The following files will need to be re-written in YAML and moved into a blueprints file: * armi/tests/geom1Assem.xml * armi/tests/geom.xml * armi/tests/ThRZGeom.xml * armi/tests/trz_geom.xml * armi/tests/zpprTestGeom.xml Though, maybe some/all of...

I would _love_ to remove geom files entirely. There are still a couple of features blueprint files don't support that need translating over. I can't find my notes at the...