John Stilley
John Stilley
@youngmit Sorry, I couldn't tell how to grab a list of all the plugins. I like `App.describe()`. If the plugins are external executables, I would also vote for grabbing their...
@onufer Is this different than #819 ?
We have raised the code coverage from 60% to 83%: https://coveralls.io/builds/51061594/source?filename=armi%2Fbookkeeping%2Fdb%2FcompareDB3.py I think most of what is left are exceptions and errors. Which we have not done a lot of...
I wouldn't mind moving the GUI to a static JavaScript web browser tool. We could keep the current workflow, where it is spawned via the same commandline, and it doesn't...
Bump. Needs `black` formatting. (I'd do it for your, but it's in your repo fork.)
@ntouran This probably just needs to be merged with `main`. @drewj-usnctech This PR has been open too long, how do you feel about it? I'd like to move this forward.
@keckler @jakehader @ntouran @albeanth FYI
It appears `Block` has a first-draft version of `__deepcopy__`, that doesn't (yet) use weakref: https://github.com/terrapower/armi/blob/8c46f8c4f625fcf7e72fdca45801afe46ec105aa/armi/reactor/blocks.py#L138 Ditto for `Core`: https://github.com/terrapower/armi/blob/0c7ef201c9f1ce5256e925b127b4a49c40659456/armi/reactor/reactors.py#L247 `Reactor`: https://github.com/terrapower/armi/blob/0c7ef201c9f1ce5256e925b127b4a49c40659456/armi/reactor/reactors.py#L95 And, for some reason, `ParameterCollection`: https://github.com/terrapower/armi/blob/260f518fb9e54d14149fb5969ce83547e52bd6f6/armi/reactor/parameters/parameterCollections.py#L275 There is some...
Well, the plot thickens. I think that is actually as it should be. So we are deep copying when we shouldn't be, but handling it with some nuance in others....
The original issue can be found here: https://github.com/theJollySin/mazelib/issues/118