armi
armi copied to clipboard
Bug fix for setting nuclide categories on the `HexToRZThetaConverter`
Description
Add mapping from the original core's nuclide categorization to
the convert core within the HexToRZThetaConverter. This is
important for lattice physics temperatures and was a bug.
Update the HexToRZThetaConverter type strings to leverage
the Flags system.
Checklist
- [x] The code is understandable and maintainable to people beyond the author.
- [x] Tests have been added/updated to verify that the new or changed code works.
- [x] There is no commented out code in this PR.
- [x] The commit message follows good practices.
- [x] All docstrings are still up-to-date with these changes.
If user exposed functionality was added/changed:
The following are not applicable for this change
- [ ] Documentation added/updated in the
docfolder. - [ ] New or updated dependencies have been added to
setup.py.
Is this PR still active?
Is this PR still active?
It's a draft because I haven't had time to get back to it. Still an important bug to fix but I got stuck