John Stilley

Results 306 comments of John Stilley

Thisf plotting method is in a strange module, but could also traffic more in figure objects: https://github.com/terrapower/armi/blob/a857635c4f91147805117d57ac5fa3fa93374a1a/armi/nuclearDataIO/xsNuclides.py#L234-L247

Do you know if these two changes will break any of our `Plugin`s? 1. Removed `quiet` kwarg from geometry and block converters as this was generally unused in the code...

As a first step to the "merge and clean the reporting tools", I have moved all the "newReport" tools into the "reporting" package. https://github.com/terrapower/armi/pull/867 Honestly, I don't know why the...

I also note that `armi/utils/reportPlotting.py` imports extensively from the "old" armi reports tools. I was also able to find downstream projects using: * `from armi.bookkeeping import report` * `report.setData()` *...

Also, happily, I couldn't find anyone outside of ARMI using the "newReport" tools. So, we can change that dubious name to something else with ease.

As to your Point (2) above, I think if you want to make a chunk of data "standard" in this way, we would use a class. So there would be...

This might be an interesting problem for me to solve, to help me learn my way around our tooling.

Well, we can infer the units of `density3`: https://github.com/terrapower/armi/blob/bc556fc5ce3f0445a4b1e841f00b8bdc3888f5a3/armi/materials/material.py#L413-L421

@ntouran Can you fill in the blanks above, for what these units should be?

Okay, I have a few thoughts. 1. I can definitely see how this could be generally useful to most users. And I like the idea of supporting it, except... 2....